Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port over fix to number as float #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

port over fix to number as float #119

wants to merge 1 commit into from

Conversation

s-cork
Copy link
Contributor

@s-cork s-cork commented Nov 10, 2022

basically we fail for numbers that have a partial match to the float test e.g.

0x1234e455

will get converted to a float but should be an int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertjan albertjan Awaiting requested review from albertjan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-cork