Open
Conversation
- Implement global config system with set_config, get_config, reset_config, config_context - Integrate global config into BaseObject.get_config with priority: local > global > defaults - Add extension point __skbase_get_config__ for downstream packages - Add comprehensive tests
for more information, see https://pre-commit.ci
- Add missing newlines at end of files - Remove trailing whitespace - Sort imports
- Add skbase.config modules to SKBASE_MODULES and SKBASE_PUBLIC_MODULES - Add config functions to SKBASE_PUBLIC_FUNCTIONS_BY_MODULE and SKBASE_FUNCTIONS_BY_MODULE
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 85.07% 83.57% -1.50%
==========================================
Files 45 55 +10
Lines 3015 3964 +949
==========================================
+ Hits 2565 3313 +748
- Misses 450 651 +201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #478
What does this implement/fix? Explain your changes.
This implements a global config manager for skbase as requested in issue #478.
It adds a global config system that allows setting config values globally, with priority order:
It also includes an extension point
__skbase_get_config__for downstream packages to provide their own global configs (e.g., for specific object types like forecasters in sktime).The implementation includes:
skbase.configmodule withget_config,set_config,reset_config,config_contextBaseObject.get_configwith the specified priorityDoes your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Any other comments?
This is based on the draft in #149 but adjusted to meet the exact requirements from #478, including the priority order and extension for object types.
PR checklist
For all contributions
For code contributions