Skip to content

[ENH] add test for all_objects tag filtering#474

Open
arnavk23 wants to merge 10 commits intosktime:mainfrom
arnavk23:fix/issue-162
Open

[ENH] add test for all_objects tag filtering#474
arnavk23 wants to merge 10 commits intosktime:mainfrom
arnavk23:fix/issue-162

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Nov 19, 2025

Reference Issues/PRs

Fixes #162

What does this implement/fix? Explain your changes.

Added a unit test to test_lookup.py that creates a temporary package with a class that has a tag and asserts all_objects(..., filter_tags=...) returns it.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've reviewed the project documentation on contributing
  • I've added myself to the list of contributors.
  • The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
    the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions
  • Unit tests have been added covering code functionality
  • Appropriate docstrings have been added (see documentation standards)
  • New public functionality has been added to the API Reference

@arnavk23 arnavk23 changed the title ENH: add test for all_objects tag filtering [ENH] add test for all_objects tag filtering Nov 20, 2025
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (306958d) to head (921e521).
⚠️ Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   85.07%   83.33%   -1.74%     
==========================================
  Files          45       52       +7     
  Lines        3015     3889     +874     
==========================================
+ Hits         2565     3241     +676     
- Misses        450      648     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly added the enhancement Adding new functionality label Jan 19, 2026
Copy link
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you kindly explain whether this causes any permanent side effects to the module structure? (if not, why not)

@arnavk23
Copy link
Contributor Author

arnavk23 commented Jan 20, 2026

Thanks!

Could you kindly explain whether this causes any permanent side effects to the module structure? (if not, why not)

This PR is non-invasive with respect to the module structure. It just improves coverage of tests, which only affects testing environments and development workflows, not the operational code structure itself.

@arnavk23 arnavk23 requested a review from fkiraly January 27, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adding new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] ensure test coverage of #161 failure case

2 participants