[ENH] add test for all_objects tag filtering#474
[ENH] add test for all_objects tag filtering#474arnavk23 wants to merge 10 commits intosktime:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 85.07% 83.33% -1.74%
==========================================
Files 45 52 +7
Lines 3015 3889 +874
==========================================
+ Hits 2565 3241 +676
- Misses 450 648 +198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
Could you kindly explain whether this causes any permanent side effects to the module structure? (if not, why not)
This PR is non-invasive with respect to the module structure. It just improves coverage of tests, which only affects testing environments and development workflows, not the operational code structure itself. |
Reference Issues/PRs
Fixes #162
What does this implement/fix? Explain your changes.
Added a unit test to
test_lookup.pythat creates a temporary package with a class that has a tag and assertsall_objects(..., filter_tags=...)returns it.Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions