Fix reruns with same build #83
Open
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to have to randomize the build_id on each reproduction run, thus we can just override the rspecq state when we publish the queue.
Considering that we, now, can re-run the same builds using `--reproduce` it makes sense to simplify the re-run command we report in sentry.
vfxcode
requested review from
agis,
astathopoulos,
NikosGkotsis,
npaschos and
mkiriakos
fragoulis
approved these changes
Oct 27, 2022
fragoulis
reviewed
Oct 27, 2022
| @@ -127,8 +129,8 @@ OptionParser.new do |o| | |||
| end | |||
| end.parse! | |||
|
|
|||
| opts[:build] ||= ENV["RSPECQ_BUILD"] | |||
| opts[:worker] ||= ENV["RSPECQ_WORKER"] | |||
| opts[:build] ||= ENV["RSPECQ_BUILD"] || DEFAULT_BUILD | |||
There was a problem hiding this comment.
This however makes sense only when reproduction is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of Quality of Life improvement. Makes consecutive reproduction runs easier.