EVE motion histories just after homebridge restating. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi skrollme,
This plug-in is very useful to know my family's getting home. Thank you very much.
A small glitch is a EVE motion history would become out of sync after homebridge restarting, and is resolved if new motion event will arise. I guess the screenshot in Reddit (https://www.reddit.com/r/homebridge/comments/fsx0eb/people_x_fakegato_issue_pluggin_is_recognising/) shows such inconsistence state. Seems that EVE doesn't receive motion history before the restarting, and history status is kept as lastly updated.
As far as my experience, adding a extra one history record of current status will resolve this inconsistency, and this PR adds such record.
If you will agree to my observations, and integrate this PR, It's my great pleasure.
Thanks in advance.