Merge branch 'develop'

* develop: fix for a low-battery-warning issue
skrollme · Jan 2, 2019 · f5a9ba1 · f5a9ba1
2 parents eb2dbbc + 506e1dd
commit f5a9ba1
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,5 +1,8 @@
 ## version history
 
+### 0.4.2
+- hopefully fixed a problem which caused the low-battery warning to persist even after replacing the module's battery (Issue #21)
+
 ### 0.4.1
 - setting min value for co2 for investigating history gaps
 - anti-crash-fix for netatmo's current API problems

diff --git a/accessory/eveatmo-rain-accessory.js b/accessory/eveatmo-rain-accessory.js
@@ -96,7 +96,7 @@ module.exports = function(pHomebridge) {
 				this.batteryPercent = weatherData.batteryPercent;
 				dataChanged = true;
 			}
-			if (weatherData.lowBattery && this.lowBattery != weatherData.lowBattery) {
+			if (this.lowBattery != weatherData.lowBattery) {
 				this.lowBattery = weatherData.lowBattery;
 				dataChanged = true;
 			}

diff --git a/accessory/eveatmo-room-accessory.js b/accessory/eveatmo-room-accessory.js
@@ -142,7 +142,7 @@ module.exports = function(pHomebridge) {
 				this.batteryPercent = weatherData.batteryPercent;
 				dataChanged = true;
 			}
-			if (weatherData.lowBattery && this.lowBattery != weatherData.lowBattery) {
+			if (this.lowBattery != weatherData.lowBattery) {
 				this.lowBattery = weatherData.lowBattery;
 				dataChanged = true;
 			}

diff --git a/accessory/eveatmo-weather-accessory.js b/accessory/eveatmo-weather-accessory.js
@@ -139,7 +139,7 @@ module.exports = function(pHomebridge) {
 				this.batteryPercent = weatherData.batteryPercent;
 				dataChanged = true;
 			}
-			if (weatherData.lowBattery && this.lowBattery != weatherData.lowBattery) {
+			if (this.lowBattery != weatherData.lowBattery) {
 				this.lowBattery = weatherData.lowBattery;
 				dataChanged = true;
 			}

diff --git a/accessory/eveatmo-wind-accessory.js b/accessory/eveatmo-wind-accessory.js
@@ -96,7 +96,7 @@ module.exports = function(pHomebridge) {
 				this.batteryPercent = weatherData.batteryPercent;
 				dataChanged = true;
 			}
-			if (weatherData.lowBattery && this.lowBattery != weatherData.lowBattery) {
+			if (this.lowBattery != weatherData.lowBattery) {
 				this.lowBattery = weatherData.lowBattery;
 				dataChanged = true;
 			}

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "homebridge-eveatmo",
-	"version": "0.4.1",
+	"version": "0.4.2",
 	"description": "Homebridge plugin which adds a Netatmo weatherstation as HomeKit device and tries to act like Elgato Eve Room/Weather",
 	"license": "ISC",
 	"keywords": [