Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little details #46

Merged
merged 6 commits into from
Oct 24, 2017
Merged

Little details #46

merged 6 commits into from
Oct 24, 2017

Conversation

elrumordelaluz
Copy link
Contributor

@elrumordelaluz elrumordelaluz commented Oct 23, 2017

  1. Unify keyframes with same value

  2. Unify size props (in case will update README). Adds also a PropTypes.oneOfType to avoid warning when using a String and match the Documentation

  3. Adds style prop to pass and apply to the main SVG allowing to make the octocat transparent, for example

    <GithubCorner href={githubUrl}  style={{ 'mixBlendMode': 'darken' }}/>
    

    More use-cases in this issue from the original repo

Sice it's an SVG and its a square, needs always the same value for width and height.
@elrumordelaluz elrumordelaluz changed the title Unify keyframes with same value Little details Oct 23, 2017
Allow to customize more the gh-corner like:
```
<GithubCorner href={githubUrl}  style={{ 'mixBlendMode': 'darken' }}/>
```
to made the octocat trasnparent.

Details in [this issue](tholman/github-corners#15).
@skratchdot
Copy link
Owner

Looks good to me. Thanks for taking an interest and the time to submit a PR!

The size prop breaks backwards compatibility, so I will need to bump a major version for this, but it seems okay to me. Is the size change absolutely necessary though? If it is, we need to fix the examples on the homepage (things like:

width={80}
height={80}
).

We also need to fix the README: https://github.com/skratchdot/react-github-corner/blame/master/README.md#L49-L50

Basically, anywhere that width/height exist in this repo would need to be fixed.

@elrumordelaluz
Copy link
Contributor Author

Will update each place where reference width and height into size.

@skratchdot
Copy link
Owner

Awesome! Thanks for making these additional changes.

@skratchdot skratchdot merged commit 44d574a into skratchdot:master Oct 24, 2017
@skratchdot
Copy link
Owner

@elrumordelaluz - One thing I noticed after pulling this down and running locally: i had a test that was using "style" to set the style on the outside anchor tag. I think I'm going to rename the new "style" property you added to "svgStyle". Once I do that, I'll bump the major version and publish this on npm. Thanks again.

@skratchdot
Copy link
Owner

Just published version 2.0.0: https://www.npmjs.com/package/react-github-corner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants