Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap + TapAsync Refactoring #12

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Tap + TapAsync Refactoring #12

merged 1 commit into from
Mar 20, 2024

Conversation

skrasekmichael
Copy link
Owner

@skrasekmichael skrasekmichael commented Mar 20, 2024 •
edited
Loading

  • split .TapAsync extension methods into separate file
  • added missing .Tap and .TapAsync extension methods
  • added unit tests for .Tap and .TapAsync extension methods
  • marked one .Tap extension method as obsolete
[Obsolete("This methods seems useless, as Then methods should always unwrap returning result object.")]
Task<Result<TValue>> Tap<TValue>(this Task<Result<Result<TValue>>> resultTask, Action<TValue> func)

@skrasekmichael skrasekmichael self-assigned this Mar 20, 2024
@skrasekmichael
split tapasync into seperate file, added missing tap and tapasync ext…
b781b44 
…ension methods, marked method as obsolete, added unit test for tap and tapasync
@skrasekmichael skrasekmichael merged commit ee86b1f into main Mar 20, 2024
1 check passed
@skrasekmichael skrasekmichael deleted the tap-tests branch March 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skrasekmichael skrasekmichael

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skrasekmichael