Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: AWS s3 helper to download files from s3 #64

Merged
merged 7 commits into from
Jan 15, 2024
Merged

add: AWS s3 helper to download files from s3 #64

merged 7 commits into from
Jan 15, 2024

Conversation

sreeram-narayanan
Copy link
Contributor

  • add: aws helper package
  • add: s3 file download function

@sreeram-narayanan sreeram-narayanan self-assigned this Jan 5, 2024
@sreeram-narayanan
Copy link
Contributor Author

@ydlamba FYI

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 5, 2024
View reviewed changes
aws/s3.go Dismissed Show dismissed Hide dismissed
aws/s3.go Dismissed Show dismissed Hide dismissed
@sreeram-narayanan sreeram-narayanan marked this pull request as draft January 5, 2024 12:35
@sreeram-narayanan sreeram-narayanan marked this pull request as ready for review January 5, 2024 12:36
vabshere
vabshere reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@vabshere vabshere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add support for presigned urls here
I checked. Is novpce regex supposed to support this?

aws/s3.go Outdated Show resolved Hide resolved
aws/s3.go Outdated Show resolved Hide resolved
vabshere
vabshere reviewed Jan 11, 2024
View reviewed changes
aws/s3.go Show resolved Hide resolved
@sreeram-narayanan sreeram-narayanan merged commit 4e82379 into master Jan 15, 2024
3 checks passed
@sreeram-narayanan sreeram-narayanan deleted the s3-download-file branch January 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vabshere vabshere vabshere approved these changes

@vipul-sharma20 vipul-sharma20 Awaiting requested review from vipul-sharma20

Assignees

@sreeram-narayanan sreeram-narayanan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreeram-narayanan @vabshere