refactor: clean up posthandler logic and tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
November 29, 2023 11:27
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
davidterpay
reviewed
Dec 5, 2023
| feeCoins = feeTx.GetFee() | ||
|
|
||
| // Ensure that the provided fees meet the minimum | ||
| minGasPrices := feesDec | ||
| minGasPrices := minFeesDecCoins |
There was a problem hiding this comment.
Does there need to be a check on whether the provided gas limit > consumed gas limit or do you think it's fine for the gas meter to handle that? On it's own you can technically have a greater gas consumed than gas limit rn.
There was a problem hiding this comment.
The gas meter will automatically do that in the background if the tx ever exceeds the gas limit
davidterpay
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.