Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to v0.52 part 1 #150

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Conversation

technicallyty
Copy link

@technicallyty technicallyty commented Feb 3, 2025

this PR updates SDK dependency to v0.52 and ensures tests pass. the module code is updated as well. there is still usage of deprecated code, however, which can be updated in part 2, where the keeper should be migrated to use Environment and context.Context.

@technicallyty technicallyty marked this pull request as draft February 3, 2025 17:30
tests/e2e/suite.go Outdated Show resolved Hide resolved
tests/e2e/suite.go Show resolved Hide resolved
tests/e2e/suite.go Show resolved Hide resolved
testutils/fixture/fixture.go Outdated Show resolved Hide resolved
testutils/fixture/fixture.go Show resolved Hide resolved
testutils/fixture/fixture.go Show resolved Hide resolved
x/feemarket/ante/expected_keepers.go Show resolved Hide resolved
@@ -198,6 +199,10 @@ func TestAnteHandleMock(t *testing.T) {
for _, tc := range testCases {
t.Run(fmt.Sprintf("Case %s", tc.Name), func(t *testing.T) {
s := antesuite.SetupTestSuite(t, tc.Mock)
s.Ctx = s.Ctx.WithBlockHeight(420)
if tc.Simulate {
s.Ctx = s.Ctx.WithExecMode(sdk.ExecModeSimulate)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we no longer use the simulate bool so we need this

x/feemarket/keeper/keeper.go Outdated Show resolved Hide resolved
x/feemarket/module.go Show resolved Hide resolved
@technicallyty technicallyty marked this pull request as ready for review February 5, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants