Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove BlockSDK Module #530

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

davidterpay
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.03%. Comparing base (bfdd584) to head (5122363).

Files Patch % Lines
block/mempool.go 50.00% 2 Missing ⚠️
testutils/keeper/keeper.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   43.46%   44.03%   +0.56%     
==========================================
  Files          75       63      -12     
  Lines        3106     2782     -324     
==========================================
- Hits         1350     1225     -125     
+ Misses       1626     1431     -195     
+ Partials      130      126       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay marked this pull request as ready for review June 24, 2024 15:12
@davidterpay davidterpay merged commit 97e5731 into main Jun 24, 2024
11 of 12 checks passed
@davidterpay davidterpay deleted the terpay/sudo-rm-blocksdkmodule branch June 24, 2024 16:56
mergify bot pushed a commit that referenced this pull request Jun 24, 2024
(cherry picked from commit 97e5731)

# Conflicts:
#	abci/abci.go
#	abci/abci_test.go
#	abci/checktx/check_tx_test.go
#	abci/utils_test.go
#	block/mempool.go
#	block/mempool_test.go
#	tests/app/app.go
#	tests/app/config.go
#	tests/e2e/block_sdk_e2e_test.go
#	tests/integration/integration_test.go
#	tests/integration/network/network_test.go
#	testutils/keeper/keeper.go
#	testutils/mempool/mempool.go
#	testutils/networksuite/networksuite.go
mergify bot pushed a commit that referenced this pull request Jun 24, 2024
(cherry picked from commit 97e5731)

# Conflicts:
#	abci/abci.go
#	abci/abci_test.go
#	abci/checktx/check_tx_test.go
#	abci/utils_test.go
#	block/mempool.go
#	block/mempool_test.go
#	tests/e2e/block_sdk_e2e_test.go
#	testutils/networksuite/networksuite.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants