Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge benmanns/goworker#85 #3

Closed
wants to merge 16 commits into from
Closed

Merge benmanns/goworker#85 #3

wants to merge 16 commits into from

Commits on Jul 26, 2022

  1. CHANGELOG: Stareted the CHANGELOG

    Mentioning the 1.4 that we'll create is based on master, as the last release is 1.3 and it's old
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    7ad8a38 View commit details
    Browse the repository at this point in the history
  2. goworker: replace redigo with go-redis

    kerak19 authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    915dfae View commit details
    Browse the repository at this point in the history
  3. chore: rebase go.sum

    skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    4d43e80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2346ce1 View commit details
    Browse the repository at this point in the history
  5. worker: Add logic for heatbeat and prune

    This logic is ported from the Ruby.
    
    It allows each worker to heartbeat Redis so if everything is killed instead of keeping them on the
    DB it'll try to prun them after a while (5').
    
    The only logic ont ported from Ruby is the one about checking the PID.
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    106314a View commit details
    Browse the repository at this point in the history
  6. CHANGELOG: Bump version 0.1.5

    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    1e9cce2 View commit details
    Browse the repository at this point in the history
  7. CHANGELOG: Quick release to change the module definition

    Otherwise it cannot be imported from the outseide
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f85b442 View commit details
    Browse the repository at this point in the history
  8. worker: Fix issue with go-redis syntax

    When redis returns nil they return an error with an specific logic to check it with
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    e149b39 View commit details
    Browse the repository at this point in the history
  9. CHANGELOG: Bump release

    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f5808fc View commit details
    Browse the repository at this point in the history
  10. goworker: Added a function 'Closed()' that will return when the proce…

    …ss fully closed
    
    It's useful when you want to exactly know when the worker has fully stopped and cleaned.
    
    This can be useful in cases in which you have to block something until the worker is closed for example
    if the worker is in goroutines and the main process is killed you could end up with workers not beeing
    cleaned so using this function would avoid this.
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    41602e2 View commit details
    Browse the repository at this point in the history
  11. CHANGELOG: Bumped to 0.1.8

    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    e2d25d6 View commit details
    Browse the repository at this point in the history
  12. goworker: Added 'MaxAgeRetries' option to the Goworker

    This option is useful to automatically remove retried failed jobs from the 'failed' queue that exceede that duration, this
    check will be done every 1m.
    
    Also changed the 'failed.FailedAt' and added 'failed.RetriedAt' and switched them to type string. The main reason is
    that the Ruby lib is setting those values in an specific format and Ruby can read multiple formats into one, but GO
    cannot and we need to actually use the same ones or the unmarshaler does not work so I decided to switch them to
    'string' and add helpers to set/get the values that will directly convert them.
    
    All the logic has more or less been ported from the Ruby version, on how to remove failed jobs and how the data
    is stored, as the 'MaxAgeRetries' is something unique from this GO version
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    fbbb9c4 View commit details
    Browse the repository at this point in the history
  13. worker: New option ForcePrune to clean workers not on the heartbeat

    This will remove workers thare could be stuck but it's not backwards compatible if enabled
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    48ca555 View commit details
    Browse the repository at this point in the history
  14. CHANGELOG: Bump version

    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    5a95af9 View commit details
    Browse the repository at this point in the history
  15. goworker: Fixed null pointer exception when running prune

    For some reason with previous tests this was not found but now it's fixed
    xescugc authored and skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    afc4ad7 View commit details
    Browse the repository at this point in the history
  16. chore: go mod tidy

    skaurus committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    c24f222 View commit details
    Browse the repository at this point in the history