Update versions #35
Update versions #35
Conversation
philoserf
commented
Sep 27, 2023
•
philoserf
commented
- update go library versions and reorganize go.mod
- update github action versions
- change how we set the go version and use the same version everywhere
- replace golangci-lint config and fix or suppress issues
philoserf
force-pushed
the
update-versions
branch
from
752648c
to
81d7578
Compare
- update go library versions and reorganize go.mod - update github action versions - change how we set go version and use the same version everywhere - replace golangci-lint config and fix or supress issues
philoserf
force-pushed
the
update-versions
branch
from
81d7578
to
a98313c
Compare
There was a problem hiding this comment.
Seems like a lot of good changes, but CI is failing.
Would it be possible, to maybe move those to separate PR's? At least moving linting related change to separate PR would be appreciated, I'd like to discuss this change further (while I'm on board with other changes).
Thanks.
| - gochecknoglobals # flags our globals | ||
| - depguard # flags our modules | ||
| - forbidigo # flags our fmt.Println | ||
| - wrapcheck # flags our unchecked errors |
There was a problem hiding this comment.
thought: I'm a bit worried about generating too much noise from linters, this is why I went with “whitelist linters” approach, but you seem to be reverting to “blacklist linters” approach here.
For me, biggest priority was from message that "errcheck" and "gocritic" raised.
I'm open to hearing your thoughts on this – it's my first year writing golang, so I don't have strong opinions of my own.
I normally do what "charm" team does and here is how they approach go linting:
https://github.com/charmbracelet/glow/blob/master/.golangci.yml
There was a problem hiding this comment.
I made changes together because the lint complaints started with deprecated function calls. I went to this style of config because, once it is set, you know your code is good or that you have intentionally decided to override the wisdom of the community.
The strange thing for me was that everything passed using act locally to check the GitHub workflows.
All of that said. I think I will also kill this approach and start again on workflow updates and dependency updates separately as I began.
