Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps #31

Closed
wants to merge 1 commit into from
Closed

Bump deps #31

wants to merge 1 commit into from

Conversation

philoserf
Copy link
Collaborator

No description provided.

@skatkov
Copy link
Owner

skatkov commented Sep 26, 2023

golangci-lint is failing now with a following error:
Error: SA1019: p.Start is deprecated: please use [Program.Run] instead. (staticcheck)

I would appreciate it if you can fix it, before we merge this PR.

@philoserf
Copy link
Collaborator Author

I would appreciate it if you can fix it, before we merge this PR.

I will take a look this evening. I thought it was some transient test condition but a replay didn’t give us joy either.

@skatkov
Copy link
Owner

skatkov commented Sep 26, 2023

If I'm not mistaken, this issue comes because we updated bubbletea framework. We can pin to older version or we have to slightly rewrite how TUI is initiated (method used now was deprecated).

@philoserf
Copy link
Collaborator Author

If I'm not mistaken, this issue comes because we updated bubbletea framework.

Ah. I hadn’t noticed because of the split direct requires. On it in a bit.

@philoserf
Copy link
Collaborator Author

I am going to dump this for a new approach.

@philoserf philoserf closed this Sep 27, 2023
@philoserf philoserf deleted the bump-deps branch September 27, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philoserf @skatkov