Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1545 state locking final - dont review yet #2024

Draft
wants to merge 291 commits into
base: develop
Choose a base branch
from

Conversation

kladkogex
Copy link
Collaborator

Description

Please provide a brief summary of your changes here. Replace this comment with your summary.

Tests

Describe how you tested the changes made in this pull request. Include specific tests you have added. Replace this comment with your testing methodology.

Performance Impact

Describe any potential impact on performance due to your changes. Include any benchmarks you performed, if applicable, and compare the results with and without your changes. Replace this comment with your performance analysis.

Base automatically changed from v3.20.0 to develop October 17, 2024 18:31
std::mutex m_receivedMutex;


list< dev::eth::Transaction > m_broadcastQueue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to carefully test it, because introduction of broadcast queue will break following calls in TransactionQueue:

  • drop()
  • waiting
  • knownTransactions
  • isTransactionKnown
  • maxNonce
  • maxCurrentNonce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants