Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1994 fix max priority fee check #1995

Open
wants to merge 4 commits into
base: v4.0.0
Choose a base branch
from
Open

#1994 fix max priority fee check #1995

wants to merge 4 commits into from

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Sep 17, 2024 •
edited
Loading

fixes #1994 . fixed the check for max priority fee per gas

added unit tests to handle the case when maxPriorityFeePerGas is more than maxFeePerGas
in this case transaction should not be included in the pending transactions queue with Invalid transaction format error

no performance impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev changed the base branch from develop to v4.0.0 December 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"maxFeePerGas" may be lower than maxPriorityFeePerGas
1 participant
@olehnikolaiev