-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/is 882 enable #1731
Draft
olehnikolaiev
wants to merge
7
commits into
develop
Choose a base branch
from
bug/IS-882-enable-id
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bug/is 882 enable #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
November 24, 2023 16:19
SUGGESTIONS BEFORE MERGE:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1731 +/- ##
===========================================
- Coverage 45.54% 43.75% -1.80%
===========================================
Files 356 358 +2
Lines 51685 51716 +31
===========================================
- Hits 23540 22628 -912
- Misses 28145 29088 +943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/skalenetwork/internal-support/issues/882
added unit tests at test/unittests/libweb3jsonrpc/jsonrpc.cpp: JsonRpsSuite/replayProtectedTxns