Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/is 882 enable #1731

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Bug/is 882 enable #1731

wants to merge 7 commits into from

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Nov 24, 2023

fixes https://github.com/skalenetwork/internal-support/issues/882

added unit tests at test/unittests/libweb3jsonrpc/jsonrpc.cpp: JsonRpsSuite/replayProtectedTxns

@olehnikolaiev olehnikolaiev changed the base branch from develop to v3.18.0 November 24, 2023 16:19
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #1731 (0943ddc) into v3.18.0 (1af8e4d) will decrease coverage by 1.80%.
Report is 1 commits behind head on v3.18.0.
The diff coverage is 100.00%.

❗ Current head 0943ddc differs from pull request most recent head 7d97410. Consider uploading reports for the commit 7d97410 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1731      +/-   ##
===========================================
- Coverage    45.54%   43.75%   -1.80%     
===========================================
  Files          356      358       +2     
  Lines        51685    51716      +31     
===========================================
- Hits         23540    22628     -912     
- Misses       28145    29088     +943     

Base automatically changed from v3.18.0 to develop January 22, 2024 19:07
@DmytroNazarenko DmytroNazarenko marked this pull request as draft October 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant