Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.5.1 beta (2.2.1 release) #997

Merged
merged 194 commits into from
Oct 19, 2023
Merged

2.5.1 beta (2.2.1 release) #997

merged 194 commits into from
Oct 19, 2023

Conversation

badrogger
Copy link
Contributor

Node rotation fixes

badrogger added 30 commits May 22, 2023 18:58
@badrogger
Add monitor tasks module
a18f17a
@badrogger
Split checks into separate classes for each task
9ebea08
@badrogger
Bump requirements
615d0e9
@badrogger
Add action module. Add config monitor module
91489a2
@badrogger
Add tests for config actions
70a5210
@badrogger
Add tests for container actions
9b9ac74
@badrogger
Extend action tests
a14f9b3
@badrogger
Rename container -> skaled
f45541c
@badrogger
Extract secret_key from config fixture in conftest
171cb9d
@badrogger
Save config to a new path with timestamp and rotation_id
5349ff5
@badrogger
Introduce new monitor flow
d7d433b
@badrogger
Fix config checks
1291c33
@badrogger
Add the rest of monitor types
d337640
@badrogger
Improve checks naming
5a90e8b
@badrogger
Clean config path commands logic
0eeb576
@badrogger
Improve config related actions
ae2663e
@badrogger
Updated to new config check names
fb76437
@badrogger
Handle exceptions properly for Task
19ef38f
@badrogger
Add skaled_monitor module
73801b8
@badrogger
Fix config actions tests
9a9a9d5
@badrogger
Bump pytest version to 7.x.x
dc23cf6
@badrogger
Improve skaled action test
ad49e10
@badrogger
Handle empty skaled_status file. Fix skaled_action tests
7e9e7d6
@badrogger
Fix upstream config file determination
a1218d8
@badrogger
Change logging format
2fb33a4
@badrogger
Add update config test
7007692
@badrogger
Raise custom exception for setExitTime request
7f6fb79
@badrogger
Improve actions logging
123c8ba
@badrogger
Fix config check
db18071
@badrogger
Add process name to cleaner
ed74250
dmytrotkk and others added 22 commits August 29, 2023 14:00
@dmytrotkk
Merge pull request #967 from skalenetwork/sigterm-twice
4006259 
Sigterm twice
@badrogger
Remove restart_on_exit option
7206350
@badrogger
Merge pull request #979 from skalenetwork/remove-restart-on-exit
9e808ce 
Remove restart_on_exit option
@badrogger
Filter checks before sending a message
f4fe3ed
@badrogger
Notify only API allowed skaled checks
6d57ca8
@badrogger
Fix container recreation for UpdateConfig monitor
65f5a7e
@badrogger
Fix health_test
2a53264
@badrogger
Ignore config check for TG
71d2f62
@badrogger
Fix get_all tests
7427d2e
@badrogger
Merge pull request #984 from skalenetwork/fix-notifications
905a868 
Notify only api allowed skaled checks
@badrogger
Improve tests
4e04586
@badrogger
Merge branch 'develop' into fix-update-config-monitor
80a98cb
@badrogger
Fix update_config_monitor test
456bc4d
@badrogger
Merge pull request #985 from skalenetwork/fix-update-config-monitor
73633b2 
Fix update config monitor
@badrogger
Restart both skaled and IMA during UpdateConfigMonitor
ac6b3cb
@badrogger
Pull image using cli instead of docker.py
ce618cb
@DmytroNazarenko
Merge pull request #993 from skalenetwork/989-rotation-restart-ima
17372b4 
989. Restart both IMA and skaled during PostRotationMonitor
@badrogger
Cleanup SM image after deployment
cc7f7f6
@badrogger
Fix update_config_monitor_test
b6b09a3
@DmytroNazarenko
Merge pull request #996 from skalenetwork/rmi-sm
66d9140 
Cleanup skale-manager image after deployment. Fix tests
@badrogger
Merge branch 'develop' into merge-develop
f49aeb8
@badrogger
Remove base monitor tests
0c8fd17
@badrogger badrogger changed the title 2.2.1 beta 2.5.1 beta (2.2.1 release) Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 199 lines in your changes are missing coverage. Please review.

Comparison is base (d7b6f18) 80.30% compared to head (0c8fd17) 80.26%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             beta     #997      +/-   ##
==========================================
- Coverage   80.30%   80.26%   -0.04%     
==========================================
  Files         100      101       +1     
  Lines        4980     5533     +553     
==========================================
+ Hits         3999     4441     +442     
- Misses        981     1092     +111
Files Coverage Δ
core/node.py 75.11% <ø> (-0.12%) ⬇️
core/schains/cmd.py 100.00% <100.00%> (ø)
core/schains/config/__init__.py 100.00% <ø> (ø)
core/schains/config/directory.py 93.33% <100.00%> (+3.33%) ⬆️
core/schains/dkg/broadcast_filter.py 82.43% <100.00%> (ø)
core/schains/dkg/client.py 75.30% <100.00%> (ø)
core/schains/dkg/utils.py 70.52% <100.00%> (ø)
core/schains/external_config.py 100.00% <100.00%> (ø)
core/schains/firewall/__init__.py 100.00% <100.00%> (ø)
core/schains/firewall/rule_controller.py 88.11% <ø> (+1.98%) ⬆️
... and 33 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review October 19, 2023 10:44
@DmytroNazarenko DmytroNazarenko merged commit 23147a6 into beta Oct 19, 2023
3 of 7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the merge-develop branch October 19, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dmytrotkk dmytrotkk Awaiting requested review from dmytrotkk dmytrotkk is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badrogger @DmytroNazarenko @dmytrotkk