Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure firewall rules using nftables #1136

Open
wants to merge 15 commits into
base: v2.9.x
Choose a base branch
from

Fix tests

517a3a8
Select commit
Loading
Failed to load commit list.
Open

Configure firewall rules using nftables #1136

Fix tests
517a3a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2024 in 1s

81.67% (-1.52%) compared to 007a365

View this Pull Request on Codecov

81.67% (-1.52%) compared to 007a365

Details

Codecov Report

Attention: Patch coverage is 34.87179% with 127 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (007a365) to head (517a3a8).

Files with missing lines Patch % Lines
core/schains/firewall/nftables.py 27.97% 121 Missing ⚠️
core/schains/firewall/firewall_manager.py 60.00% 4 Missing ⚠️
core/schains/firewall/iptables.py 50.00% 1 Missing ⚠️
core/schains/firewall/rule_controller.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v2.9.x    #1136      +/-   ##
==========================================
- Coverage   83.18%   81.67%   -1.52%     
==========================================
  Files         102      103       +1     
  Lines        6323     6516     +193     
==========================================
+ Hits         5260     5322      +62     
- Misses       1063     1194     +131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov