Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure firewall rules using nftables #1136

Open
wants to merge 17 commits into
base: v2.9.x
Choose a base branch
from
Open

Configure firewall rules using nftables #1136

wants to merge 17 commits into from

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 18, 2024 •
edited
Loading

Changes

  • Use nftables instead of iptables to configure rules.

Testing

  • Tested on local network.
  • Added unit tests.

Performance

  • Changes should not affect performance of the system.

@badrogger badrogger changed the title Nftables Configure firewall rules using nftables Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.80392% with 133 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (007a365) to head (80f773b).

Files with missing lines Patch % Lines
core/schains/firewall/nftables.py 28.16% 125 Missing ⚠️
core/schains/firewall/firewall_manager.py 54.54% 5 Missing ⚠️
core/schains/firewall/iptables.py 50.00% 2 Missing ⚠️
core/schains/firewall/rule_controller.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v2.9.x    #1136      +/-   ##
==========================================
- Coverage   83.18%   81.60%   -1.58%     
==========================================
  Files         102      103       +1     
  Lines        6323     6525     +202     
==========================================
+ Hits         5260     5325      +65     
- Misses       1063     1200     +137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger linked an issue Nov 25, 2024 that may be closed by this pull request
Add support of Ubuntu 22 #1112
Open
@badrogger badrogger marked this pull request as ready for review November 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dmytrotkk dmytrotkk Awaiting requested review from dmytrotkk dmytrotkk is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of Ubuntu 22
2 participants
@badrogger @DmytroNazarenko