Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#971 handle errors while parsing broadcast events #1031

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Dec 20, 2023

fixes #971

handle all possible web3 errors and errors in communicating with geth while looking for broadcast during dkg.
doesn't need any new tests
doesn't affect performance

@olehnikolaiev olehnikolaiev linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (bba42e4) 80.99% compared to head (aff6b22) 80.95%.

Files Patch % Lines
core/schains/dkg/broadcast_filter.py 75.86% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.6.x    #1031      +/-   ##
==========================================
- Coverage   80.99%   80.95%   -0.05%     
==========================================
  Files         101      101              
  Lines        5566     5570       +4     
==========================================
+ Hits         4508     4509       +1     
- Misses       1058     1061       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroNazarenko DmytroNazarenko merged commit 2d97f91 into v2.6.x Jan 10, 2024
4 of 7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/971-parsing-broadcast-events-failed branch January 10, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing broadcast events process is failed
3 participants