Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skaled config broken by automatic repair option #1025

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Dec 10, 2023

Changes:

  • Fixed schain config generation (new option ended up in schain config itself, but skaled does not allow any unused options) by moving automatic_repair to node -> admin section

Peformance:

  • No performance related changes were made

Unit tests:

  • Modified existing unit tests

Testing:

  • Tested on local network by creating schain.

@badrogger badrogger marked this pull request as ready for review December 10, 2023 14:00
@badrogger badrogger linked an issue Dec 10, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ae0367) 80.31% compared to head (7b9d1f5) 80.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1025      +/-   ##
===========================================
+ Coverage    80.31%   80.32%   +0.01%     
===========================================
  Files          101      101              
  Lines         5542     5545       +3     
===========================================
+ Hits          4451     4454       +3     
  Misses        1091     1091              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroNazarenko DmytroNazarenko merged commit 0a1faef into develop Dec 11, 2023
8 of 9 checks passed
@DmytroNazarenko DmytroNazarenko deleted the fix-automatic-repair branch December 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create flag to save data dir for tests
2 participants