Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to switch off automatic repair #1024

Merged
merged 14 commits into from
Dec 8, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Dec 7, 2023

Changes:

  1. Add option to disable repair procedure that was triggered by skaled.
  2. Port ima check fix to develop versions.

Performance:

  • No performance changes were introduced.

Unit tests:

  • Changed exiting tests, coverage not affected.

Testing:

  • Tested on local network by manualy changing skaled.status i.e. emulating state root issue.

@badrogger badrogger linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (253a84c) 80.27% compared to head (84d2e66) 80.31%.

Files Patch % Lines
core/schains/monitor/main.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1024      +/-   ##
===========================================
+ Coverage    80.27%   80.31%   +0.04%     
===========================================
  Files          101      101              
  Lines         5535     5542       +7     
===========================================
+ Hits          4443     4451       +8     
+ Misses        1092     1091       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review December 7, 2023 17:10
DmytroNazarenko
DmytroNazarenko previously approved these changes Dec 7, 2023
@badrogger
Copy link
Contributor Author

badrogger commented Dec 7, 2023

automatic_repair will be read from node -> common section.

  qanet:
    server:
      cpu_total: 8
      cpu_physical: 1
      memory: 32000000000
      swap: 16000000000
      disk: 200000000000
    package:
      iptables-persistent: 1.0.4
      lvm2: 2.02.0
      btrfs-progs: 4.15.1
      lsof: "4.89"
      psmisc: 23.1-1
    docker:
      docker-api: 1.41.0
      docker-engine: 20.10.7
      docker-compose: 1.27.4
    schain:
      revertableFSPatchTimestamp: 1000000
      contractStoragePatchTimestamp: 1000000
      snapshotIntervalSec: 0
      emptyBlockIntervalMs: 10000
      snapshotDownloadTimeout: 18000
      snapshotDownloadInactiveTimeout: 120
    schain_cmd:
      ["-v 3", "--web3-trace", "--enable-debug-behavior-apis", "--aa no"]
    node:
      admin:
        automatic_repair: false
      common:
        bindIP: "0.0.0.0"
        logLevel: "info"
        logLevelConfig: "info"

@DmytroNazarenko DmytroNazarenko merged commit 5ae0367 into develop Dec 8, 2023
6 checks passed
@DmytroNazarenko DmytroNazarenko deleted the switch-off-automatic-repair branch December 8, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create flag to save data dir for tests
3 participants