Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return IMA agent version after migration in schains/containers route #1017

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Dec 5, 2023

Changes:

  • Return IMA agent version after migration in schains/containers route. If it's not specified, return the regular one.

Peformance:

  • No performance changes were introduced.

Unit tests:

  • Fixed existing unit test.

Testing:

  • Tested on local network by requesting curl http://127.0.0.1:3009/status/schain-containers-versions.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a50774) 80.27% compared to head (371bc01) 80.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1017      +/-   ##
==========================================
+ Coverage   80.27%   80.30%   +0.03%     
==========================================
  Files         101      101              
  Lines        5535     5535              
==========================================
+ Hits         4443     4445       +2     
+ Misses       1092     1090       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review December 6, 2023 12:09
@DmytroNazarenko DmytroNazarenko merged commit 122305b into stable Dec 6, 2023
6 of 7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the ima-check-hotfix branch December 6, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API request method '/status/schain-containers-versions' returns the previous version of IMA
3 participants