Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit on failed broadcast and alright transactions #1013

Merged
merged 25 commits into from
Dec 10, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 27, 2023

Changes:

  1. Updated to skale.py 6.1.x with fixed exception handling.
  2. Do not swallow exceptions from broadcast and alright transactions.
  3. Add last completed step to DKGResult.
  4. Add ComplaintReason enum.
  5. Add more DKG unit tests.
  6. Switch to anvil to speed up overall test execution.
  7. Update base image to python3.11.
  8. Bump dependecies.

Performance:

  1. Performance should not be affected.

Unit tests:

  1. Added more unit tests in dkg_tests/main_test.py

Testing procedure:

  1. Drain node's wallet before dkg.
  2. Create schain.
  3. Make sure broadcast failed.
  4. Refill wallet balance.
  5. Make sure broacast is eventually sent and dkg completed.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (253a84c) 80.27% compared to head (c4a6f4c) 80.94%.
Report is 9 commits behind head on v2.6.x.

Files Patch % Lines
core/node.py 37.50% 5 Missing ⚠️
core/schains/dkg/client.py 81.81% 4 Missing ⚠️
core/schains/monitor/action.py 20.00% 4 Missing ⚠️
core/schains/dkg/main.py 72.72% 3 Missing ⚠️
core/schains/dkg/utils.py 93.93% 2 Missing ⚠️
web/models/schain.py 33.33% 2 Missing ⚠️
web/migrations.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v2.6.x    #1013      +/-   ##
==========================================
+ Coverage   80.27%   80.94%   +0.67%     
==========================================
  Files         101      101              
  Lines        5535     5615      +80     
==========================================
+ Hits         4443     4545     +102     
+ Misses       1092     1070      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review November 28, 2023 11:38
@badrogger badrogger requested review from olehnikolaiev, dmytrotkk and DmytroNazarenko and removed request for kladkogex and dmytrotkk November 28, 2023 11:38
@@ -7,7 +7,7 @@ env:
IMA_TAG: "1.3.4-beta.5"
SGX_WALLET_TAG: "1.83.0-beta.5"
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
PYTHON_VERSION: 3.8
PYTHON_VERSION: 3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are running with python 3.9, but image builds with 3.11

@badrogger badrogger merged commit 0033065 into v2.6.x Dec 10, 2023
4 of 6 checks passed
@badrogger badrogger deleted the exit-on-failed-dkg-transactions branch December 10, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants