Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update config skaled monitor even if config updated but skaled still exited #1008

Merged
merged 33 commits into from
Nov 7, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 7, 2023

Changes:

  • Run UpdateConfigSkaledMonitor when skaled exited with ExitTimeReached: true and zero exit code regardless of outdated skaled config.
  • Fix removing schain during dkg.
  • Improve logging.

Testing:

  • No performance related changes were made.
  • Added unit test.
  • Tested on local network.

dmytrotkk and others added 30 commits September 20, 2022 15:08
New beta (2.1 release candidate)
Beta 2.1 (release candidate)
New beta (add --no-snapshot-majority option to chain cmd)
…-ima

989 Hotfix. Restart both IMA and skaled during PostRotationMonitor
Cleanup SM image after smart contracts deployment
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5430007) 80.40% compared to head (aedb8ac) 80.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1008      +/-   ##
===========================================
- Coverage    80.40%   80.27%   -0.14%     
===========================================
  Files          100      101       +1     
  Lines         5523     5535      +12     
===========================================
+ Hits          4441     4443       +2     
- Misses        1082     1092      +10     
Files Coverage Δ
core/schains/checks.py 94.64% <100.00%> (ø)
core/schains/monitor/config_monitor.py 90.90% <100.00%> (+0.28%) ⬆️
core/schains/monitor/skaled_monitor.py 92.54% <100.00%> (+0.04%) ⬆️
core/schains/monitor/post_rotation_monitor.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger changed the title Merge beta to develop Run update config skaled monitor even if config updated but skaled still exited Nov 7, 2023
@badrogger badrogger marked this pull request as ready for review November 7, 2023 13:27
@DmytroNazarenko DmytroNazarenko merged commit 253a84c into develop Nov 7, 2023
7 of 12 checks passed
@DmytroNazarenko DmytroNazarenko deleted the merge-beta-to-develop branch November 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled won't be restarted again after rotation in case of a temporary error
3 participants