Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update config skaled monitor even if config updated but skaled still exited #1005

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 3, 2023

Changes:

  • Run UpdateConfigSkaledMonitor when skaled exited with ExitTimeReached: true and zero exit code regardless of outdated skaled config.
  • Fix removing schain during dkg.
  • Improve logging.

Testing:

  • No performance related changes were made.
  • Added unit test.
  • Tested on local network.

@badrogger badrogger changed the base branch from develop to beta November 3, 2023 16:18
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c42f1a6) 80.26% compared to head (7554458) 80.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             beta    #1005   +/-   ##
=======================================
  Coverage   80.26%   80.27%           
=======================================
  Files         101      101           
  Lines        5533     5535    +2     
=======================================
+ Hits         4441     4443    +2     
  Misses       1092     1092           
Files Coverage Δ
core/schains/checks.py 94.64% <100.00%> (ø)
core/schains/monitor/config_monitor.py 90.90% <100.00%> (+0.28%) ⬆️
core/schains/monitor/skaled_monitor.py 92.54% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review November 6, 2023 12:39
@badrogger badrogger merged commit aedb8ac into beta Nov 6, 2023
5 of 6 checks passed
@badrogger badrogger deleted the hotfix-update-config-monitor branch November 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled won't be restarted again after rotation in case of a temporary error
2 participants