Merge pull request #385 from skalenetwork/bug/SKALE-5014-fix-crash-wh…

…en-using-bad-zmq-socket SKALE-5014 add logs, fix crash on bad zmq socket
skalenetwork · Mar 1, 2022 · 2b62ef3 · 2b62ef3
2 parents 2def942 + e90ec02
commit 2b62ef3
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/zmq_src/ZMQServer.cpp b/zmq_src/ZMQServer.cpp
@@ -211,28 +211,29 @@ pair <string, shared_ptr<zmq::message_t>> ZMQServer::receiveMessage() {
 
     if (!socket->recv(identity.get())) {
         checkForExit();
-        // something terrible happened
-        spdlog::error("Fatal error: socket->recv(&identity) returned false. Exiting.");
-        exit(-11);
+        // bad socket type
+        spdlog::error("Error: socket->recv(&identity) returned false.");
+        throw SGXException(ZMQ_SERVER_ERROR, "Error: socket->recv(&identity) returned false.");
     }
 
     if (!identity->more()) {
         checkForExit();
-        // something terrible happened
-        spdlog::error("Fatal error: zmq_msg_more(identity) returned false. Exiting.");
-        exit(-12);
+        // bad socket type
+        spdlog::error("Error: zmq_msg_more(identity) returned false.");
+        throw SGXException(ZMQ_SERVER_ERROR, "Error: zmq_msg_more(identity) returned false.");
     }
 
     auto reqMsg = make_shared<zmq::message_t>();
 
     if (!socket->recv(reqMsg.get(), 0)) {
         checkForExit();
-        // something terrible happened
-        spdlog::error("Fatal error: socket.recv(&reqMsg, 0) returned false. Exiting");
-        exit(-13);
+        // bad socket type
+        spdlog::error("Error: socket.recv(&reqMsg, 0) returned false.");
+        throw SGXException(ZMQ_SERVER_ERROR, "Error: socket.recv(&reqMsg, 0) returned false.");
     }
 
     auto result = string((char *) reqMsg->data(), reqMsg->size());
+    spdlog::debug("Received request via ZMQ server: {}", result);
 
     return {result, identity};
 }
@@ -255,6 +256,7 @@ void ZMQServer::sendToClient(Json::Value &_result, shared_ptr <zmq::message_t> &
         if (!s_send(*socket, replyStr)) {
             exit(-16);
         }
+        spdlog::debug("Send response to client: {}", replyStr);
     } catch (ExitRequestedException&) {
         throw;
     } catch (exception &e) {