Use nftables to configure firewall #800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrotkk
requested changes
Dec 23, 2024
node_cli/core/nftables.py
Outdated
| from collections import namedtuple # hotfix for tests | ||
| iptc = namedtuple('nftables', ['Chain', 'Rule']) | ||
| else: | ||
| logger.error(f'Unable to import iptc due to an error {err}') |
There was a problem hiding this comment.
should be Unable to import nftables... instead of iptc
node_cli/operations/__init__.py
Outdated
| @@ -25,5 +25,6 @@ | |||
| turn_off as turn_off_op, | |||
| turn_on as turn_on_op, | |||
| restore as restore_op, | |||
| repair_sync as repair_sync_op | |||
| repair_sync as repair_sync_op, | |||
| configure_nftables as configure_firewall | |||
There was a problem hiding this comment.
what is the point of exporting this function under a different name here?
it is used 6 times as configure_nftables and 1 time as configure_firewall - suggesting keeping just one version for consistency.
| @@ -294,13 +259,16 @@ def update(env_filepath: str, pull_config_for_schain: str, unsafe_ok: bool = Fal | |||
| error_msg = 'Cannot update safely' | |||
| error_exit(error_msg, exit_code=CLIExitCodes.UNSAFE_UPDATE) | |||
|
|
|||
| prev_version = get_meta_info().version | |||
| logger.info('HERE %s %s', __version__, prev_version) | |||
| if (__version__ == 'test' or __version__.startswith('2.6')) and prev_version == '2.5.0': | |||
There was a problem hiding this comment.
will it work ok if migrate will be executed multiple times? (let's say for 2.6.1, 2.6.2, etc)
| @@ -0,0 +1,105 @@ | |||
| import logging | |||
| return DEFAULT_SSH_PORT | ||
|
|
||
|
|
||
| def remove_between_brackets(text: str, pattern: str) -> str: |
There was a problem hiding this comment.
confusing name - maybe let's use a small docstring with a function explanation?
dmytrotkk
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Performance
Testing