Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that it is safe to update before running procedure #786

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Oct 7, 2024

Changes:

  • Added check that it is safe to update before running procedure.

Testing:

  • Added unit tests
  • Tested on local network

Performance:

  • No performance related changes was introduced

@badrogger badrogger marked this pull request as ready for review October 8, 2024 15:46
@click.option(
'--unsafe',
'unsafe_ok',
help='Allow unsafe turn-off',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb change to help='Allow unsafe update',?

@badrogger badrogger merged commit 5a53762 into v2.5.x Oct 9, 2024
3 of 4 checks passed
@badrogger badrogger deleted the safe-update branch October 9, 2024 15:51
@badrogger badrogger linked an issue Oct 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block skale node update during node rotation
3 participants