Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed old-style event log scanner for IMA messages #1633

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fixed old-style event log scanner for IMA messages #1633

merged 2 commits into from
Nov 3, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

  • Fixed old-style event log scanner for IMA messages
  • Added details about iterative event search
  • No new APIs added
  • No function arguments changed
  • No new tests needed

@sergiy-skalelabs sergiy-skalelabs self-assigned this Nov 2, 2023
@sergiy-skalelabs sergiy-skalelabs linked an issue Nov 2, 2023 that may be closed by this pull request
IMA: getPastEvents sometimes work significantly slow as expected #1620
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17a59ef) 85.79% compared to head (cb1b576) 85.79%.

❗ Current head cb1b576 differs from pull request most recent head f0ab2aa. Consider uploading reports for the commit f0ab2aa to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1633   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroNazarenko DmytroNazarenko marked this pull request as ready for review November 3, 2023 12:32
DmytroNazarenko
DmytroNazarenko approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the devnet

@DmytroNazarenko DmytroNazarenko merged commit feb3bca into develop Nov 3, 2023
12 of 15 checks passed
@DmytroNazarenko DmytroNazarenko deleted the hotfix/old-event-scan-fix-in-2.0 branch November 3, 2023 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@badrogger badrogger Awaiting requested review from badrogger

@dmytrotkk dmytrotkk Awaiting requested review from dmytrotkk

@payvint payvint Awaiting requested review from payvint

@kladkogex kladkogex Awaiting requested review from kladkogex

Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
IMA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMA: getPastEvents sometimes work significantly slow as expected
2 participants
@sergiy-skalelabs @DmytroNazarenko