Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong validation of S-Chain discovery data; improved awaiting for S-… #1597

Merged

Conversation

sergiy-skalelabs
Copy link
Contributor

  • Stronger validation of S-Chain discovery data
  • Improved awaiting for S-Chain discovery compete

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e435f1c) 85.79% compared to head (58c6bc2) 85.79%.
Report is 1 commits behind head on develop.

❗ Current head 58c6bc2 differs from pull request most recent head 289677a. Consider uploading reports for the commit 289677a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1597   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiy-skalelabs sergiy-skalelabs marked this pull request as ready for review September 19, 2023 16:57
@sergiy-skalelabs sergiy-skalelabs merged commit c9deb09 into develop Sep 19, 2023
17 checks passed
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-1596/stronger-S-Chain-discovery-checks branch September 19, 2023 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix wrong S-Chain discovery status problem
3 participants