Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticket-1413 improved SNB discovery of connected S-chains #1591

Merged
merged 1 commit into from
Sep 18, 2023
Merged

ticket-1413 improved SNB discovery of connected S-chains #1591

merged 1 commit into from
Sep 18, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

  • improved SNB discovery of connected S-chains
  • added more recognizable SNB logging messages

@sergiy-skalelabs sergiy-skalelabs self-assigned this Sep 16, 2023
@sergiy-skalelabs sergiy-skalelabs linked an issue Sep 16, 2023 that may be closed by this pull request
Processing chain data work unstable #1413
Closed
@codecov
Copy link

codecov bot commented Sep 16, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd32410) 85.79% compared to head (6ccff54) 85.79%.

❗ Current head 6ccff54 differs from pull request most recent head fe1925c. Consider uploading reports for the commit fe1925c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1591   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiy-skalelabs sergiy-skalelabs marked this pull request as ready for review September 16, 2023 13:51
@sergiy-skalelabs sergiy-skalelabs merged commit ac99e34 into develop Sep 18, 2023
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-1413/improved-SNB branch September 18, 2023 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmytrotkk dmytrotkk dmytrotkk approved these changes

@kladkogex kladkogex kladkogex approved these changes

@badrogger badrogger badrogger approved these changes

@payvint payvint Awaiting requested review from payvint

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

Assignees

@sergiy-skalelabs sergiy-skalelabs

Labels
IMA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Processing chain data work unstable
4 participants
@sergiy-skalelabs @badrogger @kladkogex @dmytrotkk