-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow noteblock to play multiple pitches in same frame #129
base: master
Are you sure you want to change the base?
Conversation
yes this works, given that I'm playing bad apple on a single noteblock without any note drops |
You need a way to limit this (10 sounds per 10 ticks) or make the noteblock unable to play identical pitches in the same frame, snynoe with a malicious intent or just a beginner at logic can easily play |
I'll try doing this |
playing |
the new implementation looks horrible, doing 72 calculations every play attempt. |
ok do you want me to reinit the array |
Doing the operation 1,000,000,000 times takes 12,438 milliseconds, which means each one takes 12.438 nanoseconds |
I only changed logic because that is the only way it is feasibly happening