Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated random dependency #9

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

athanclark
Copy link
Contributor

There isn't a breaking change by updating the upper bound of random to <1.3; I've adjusted the Cabal file to reflect this, allowing for better integration for other packages. Also, I've opted to add stack.yaml* into .gitignore to reflect the package author's lack of stack integration.

unfoldable.cabal Outdated
@@ -42,7 +42,7 @@ library
base >= 4 && < 5
, containers >= 0.5 && < 0.7
, transformers >= 0.4 && < 0.6
, random >= 1.0 && < 1.2
, random >= 1.2.0 && < 1.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this! One question: did you mean to change the lower bound here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my mistake, sorry - I thought this breaking change in the changelog was relevant, but I don't think it actually is! I'll update this MR.

reflecting unnecessary adjustment to lower bound
@sjoerdvisscher sjoerdvisscher merged commit 9285eae into sjoerdvisscher:master Sep 28, 2023
0 of 3 checks passed
@sjoerdvisscher
Copy link
Owner

Thanks! I've updated the metadata on hackage directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants