fix md5 authentication, remove guava deps #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 405
💛 - Coveralls |
|
This change is probably OK, but authentication is broken on Ubuntu for unrelated reasons, see https://bugs.launchpad.net/ubuntu/+source/sane-backends/+bug/1858051 |
Previously, the code looking for $MD5$ preambles would always return false, as the '$' characters were quoted as if they were being passed to a regexp library. Splitter.on() did not take a regex, so this pattern never matched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code looking for$MD5$ preambles would always return
false, as the '$' characters were quoted as if they were being passed to
a regexp library. Splitter.on() did not take a regex, so this pattern
never matched.