Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kernel API /api/block/getDocsInfo #12719

Closed
wants to merge 0 commits into from

Conversation

Misuzu2027
Copy link
Contributor

for _, id := range idsArg {
ids = append(ids, id.(string))
}
getRefCount := arg["getRefCount"].(bool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数名称麻烦调整为 refCountav

@@ -123,6 +124,85 @@ func GetDocInfo(blockID string) (ret *BlockInfo) {
return
}

func GetDocsInfo(blockIDs []string, getRefCount bool, getAv bool) (rets []*BlockInfo) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数名称麻烦调整为 refCountav

Copy link
Contributor Author

@Misuzu2027 Misuzu2027 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的参数名称 av 会和模块名 av 冲突:"github.com/siyuan-note/siyuan/kernel/av" ,改为 refCountParam、avParam 或 queryRefCount 、queryAv 如何?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,那就用 queryRefCountqueryAv 吧。

@88250
Copy link
Member

88250 commented Oct 7, 2024

修改期间不用 close pr 的,谢谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants