Skip to content

Conversation

@Macavity
Copy link
Contributor

As this is a new package, I am confirming:

  • The repository is public
  • Include the appropriate open source license file MIT
  • Does not involve infringing content, such as non-commercial font files

@github-actions
Copy link

Pull Request Check Report

Add 0 Icon Repo

Add 1 Plugin Repo

Macavity/siyuan-rag-assistant


Add 0 Template Repo

Add 0 Theme Repo

Add 0 Widget Repo

@TCOTC TCOTC self-requested a review October 30, 2025 14:39
@TCOTC
Copy link
Collaborator

TCOTC commented Oct 31, 2025

  • Update copyright information in LICENSE

  • package.zip does not contain index.js file, console reports error: plugin siyuan-rag-assistant has no export

  • package.zip does not contain index.css file

  • preview.png file is large, please compress it using a tool

  • Suggest replacing icon.png

  • Modify plugin.json:

     {
       "name": "siyuan-rag-assistant",
       "author": "Macavity",
       "url": "https://github.com/Macavity/siyuan-rag-assistant",
       "version": "1.0.1",
       "minAppVersion": "2.10.14", // Unless you're sure it supports this old version, please set it to a newer version
       "disabledInPublish": true,
       "backends": ["all"],
       "frontends": ["all"],
       "displayName": {
         "default": "Local LLM RAG Assistant",
         "en_US": "Local LLM RAG Assistant", // Delete this line
         "zh_CN": "本地 LLM RAG 助手"
       },
       "description": {
         "default": "A powerful AI assistant plugin for Siyuan that leverages your documents as context for intelligent conversations using local Ollama GenAI.",
         "en_US": "A powerful AI assistant plugin for Siyuan that leverages your documents as context for intelligent conversations using local Ollama GenAI.", // Delete this line
         "zh_CN": "一个强大的 AI 助手插件,利用您的文档作为上下文,使用本地 Ollama GenAI 进行智能对话。"
       },
       "readme": {
         "default": "README.md",
         "en_US": "README.md", // Delete this line
         "zh_CN": "README_zh_CN.md"
       },
       "funding": {
         "patreon": "https://www.patreon.com/paneon", // Delete this line, this page doesn't seem to have valid information
         "github": "https://github.com/sponsors/Macavity", // Change to "Macavity"
         "custom": [] // Delete this line
       },
       "keywords": [
         "local", // Delete this line
         "llm", // Delete this line
         "rag", // Delete this line
         "assistant", // Delete this line
         "ollama", // Delete this line
         "AI", // Delete this line
         "GenAI", // Delete this line
         "documents", // Delete this line
         "search",
         "retrieval",
         "augmented",
         "generation"
       ]
     }

@Macavity
Copy link
Contributor Author

Macavity commented Nov 2, 2025

@TCOTC Thank you for the feedback, I've fixed those issues.

The only one which I am not is lacking is this one:

Update copyright information in LICENSE

What is missing there? The repository has a MIT license which is present and linked.

@TCOTC
Copy link
Collaborator

TCOTC commented Nov 3, 2025

The only one which I am not is lacking is this one:

Update copyright information in LICENSE

What is missing there? The repository has a MIT license which is present and linked.

The previous copyright belonged to SiYuan. I noticed you've just updated it, so there's no issue now.

@TCOTC
Copy link
Collaborator

TCOTC commented Nov 3, 2025

  • Modify plugin.json:

       "description": {
         "default": "A powerful AI assistant……",
         "en_US": "A powerful AI assistant……", // Delete this line
         "zh_CN": "一个强大的 AI 助手插件……"
       },
       "keywords": [
         "ollama", // Delete this line
         "GenAI", // Delete this line
         "documents", // Delete this line
         "search"
       ]
  • After extracting package.zip, duplicate i18n folders appear within the i18n directory:

    image
  • Add a lifecycle method uninstall() that executes the same logic as onunload() and uses removeData() to remove configuration file plugin-settings.

@TCOTC TCOTC changed the title Add Macavity/siyuan-rag-assistant plugin Add Macavity/siyuan-rag-assistant Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants