Updated to new Active server list #809
Conversation
|
@sivel Check the request |
| key = 'id' | ||
|
|
||
| server[key] = value | ||
| server["url"] = f"http://{server['host']}/speedtest/upload.php" |
There was a problem hiding this comment.
Thanks for the patch. Shouldn't the protocol (http/https) depend on the --secure option?
There was a problem hiding this comment.
I see, https would have a negative impact on ping time if used here.
|
我在香港，测速找不到对应的测速节点，这个pr能够修复这个问题吗？ |
Yes, it could help. |
@1ras 根据这位朋友提供的帮助，增加 --secure 选项，在现有的speedtest.py代码里解决了这个问题，现在可以正常输出香港的测速节点 |
|
I use it now since two weeks and this patch works great! Please ignore my comment above regarding the http:// address for the server URL. I've tested it and when https is used, the ping times increase dramatically due to the TLS negotiation. That's most likely not what's expected, so leaving it as http even with the secure option enabled should be fine. |
|
@1265578519 I am not sure if I fully understand your comment, but this pull request and the --secure option are not the same thing. With the original version and --secure there are still many missing servers. If your closest server (Hong Kong) shows up with the --secure option, then it's more of a coincidence. |
|
Should this be merged ? It would be great to be able to use it again ! |
|
Why is this PR still open? |
Its ready to merge... |
|
Is this software still maintained ? The latest update is 4 years old... I switched to Ookla's CLI tool (https://www.speedtest.net/apps/cli). Caveat : they collect personal infos, like IP addresses. |
It is not maintained by the creator... |
|
@PeterLinuxOSS : I just installed your fork (https://github.com/PeterLinuxOSS/speedtest-cli). It works fine, thanks ! |
6 participants
I have made an update to use I have updated the src to use a new URL for fetching active servers.