Dedicated Widget Blocks: Second Attempt #2063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets this branch to where #1813 was prior to revert. Minus some changes after that PR was merged. This is used as a starting point.
Unfortunately, too many dependent changes were made at once so can't split them over multiple commits. - Setup dedicated edit component. - Improved block re-render handling after change. - Resolve dev mode remount issues. - Improve preview load handling to cut down on redundent loads. - Prevent initial preview loading issue if there's a large number of Widget Blocks present on a page. - Improved preview placeholder (spinner will now show after the first preview load). - Added additional docs. There's likely more little changes here and there that aren't covered in the above change. Lotta moving parts.
|
Working on loading the actual widget icons rather than the generic icon currently being used. |
|
I've added the block specific icons. I don't think the existing widget icons (known internally as banner) look very good here so I've opted to instead look for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #1813. Please refer to that PR for information regarding changes made prior to anything in this PR.
Unfortunately, too many changes that depended on each other or for the blocks to simply function so I couldn't split them over multiple commits.
Here's a rough summary of changes post #1813:
There are likely more little changes here and there that aren't covered in the above change. There are a lot of moving parts.