-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTA: Add Center Top/Button Button Alignments #1643
Conversation
@Misplon What are your thoughts on adding an optional (due to the pre-existing nature of the widget) responsive collapse for the left and right alignments? We could call it... say, Mobile Button Layout (could also introduce a Tablet) and provide the following options:
I think it wouldn't be a bad idea to introduce it in this PR (unless it was to be merged really quickly) as it'll benefit from the top alignment and the LESS cleanup. |
Thanks, mate; yeah, agreed. Let's re-think this slightly. Can we perhaps rename the setting to something like Alignment? How do you want to do this? Within a Responsive section?
|
We can do this, but we'll need to rename the center top/bottom settings as they don't really make sense when the setting is called Alignment.
I opted to add a single setting below the alignment setting. If we were to introduce other responsive settings a dedicated section may be worth it but with only a single one it's hard to justify. |
This PR could resolve #457 in its current state. |
Resolve #1637