Skip to content

Commit

Permalink
Remove landmark roles
Browse files Browse the repository at this point in the history
* With better browser support, these roles aren't needed now.
* Most newer browsers imply them via HTML5 semantics. See: http://html5doctor.com/on-html-belts-and-aria-braces/
  • Loading branch information
Misplon committed Oct 18, 2017
1 parent eb54f83 commit f610e07
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 15 deletions.
2 changes: 1 addition & 1 deletion 404.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
get_header(); ?>

<div id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<section class="error-404 not-found">
<header class="page-header">
Expand Down
2 changes: 1 addition & 1 deletion archive.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
get_header(); ?>

<div id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<?php if ( have_posts() ) : ?>
<header class="page-header">
Expand Down
4 changes: 2 additions & 2 deletions footer.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<?php do_action( 'siteorigin_north_footer_before' ); ?>

<footer id="colophon" class="site-footer <?php if ( ! siteorigin_setting( 'footer_constrained' ) ) echo 'unconstrained-footer'; if ( is_active_sidebar( 'footer-sidebar' ) ) echo ' footer-active-sidebar'; ?>" role="contentinfo">
<footer id="colophon" class="site-footer <?php if ( ! siteorigin_setting( 'footer_constrained' ) ) echo 'unconstrained-footer'; if ( is_active_sidebar( 'footer-sidebar' ) ) echo ' footer-active-sidebar'; ?>">

<?php do_action( 'siteorigin_north_footer_top' ); ?>

Expand All @@ -28,7 +28,7 @@
if ( is_active_sidebar( 'footer-sidebar' ) ) {
$siteorigin_north_sidebars = wp_get_sidebars_widgets();
?>
<div class="widgets widget-area widgets-<?php echo count( $siteorigin_north_sidebars['footer-sidebar'] ) ?>" role="complementary" aria-label="<?php esc_attr_e( 'Footer Sidebar', 'siteorigin-north' ); ?>">
<div class="widgets widget-area widgets-<?php echo count( $siteorigin_north_sidebars['footer-sidebar'] ) ?>" aria-label="<?php esc_attr_e( 'Footer Sidebar', 'siteorigin-north' ); ?>">
<?php dynamic_sidebar( 'footer-sidebar' ); ?>
</div>
<?php
Expand Down
7 changes: 3 additions & 4 deletions header.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
} ?>
<div id="topbar-widgets" class="container">
<?php $siteorigin_north_masthead_sidebar = wp_get_sidebars_widgets(); ?>
<div class="widgets widgets-<?php echo count( $siteorigin_north_masthead_sidebar['topbar-sidebar'] ) ?>" role="complementary" aria-label="<?php esc_attr_e( 'Top Bar Sidebar', 'siteorigin-north' ); ?>">
<div class="widgets widgets-<?php echo count( $siteorigin_north_masthead_sidebar['topbar-sidebar'] ) ?>" aria-label="<?php esc_attr_e( 'Top Bar Sidebar', 'siteorigin-north' ); ?>">
<?php dynamic_sidebar( 'topbar-sidebar' ); ?>
</div>
</div><!-- #topbar-widgets -->
Expand All @@ -50,8 +50,7 @@
<?php endif; ?>

<?php if ( ! siteorigin_page_setting( 'hide_masthead', false ) ) : ?>
<header id="masthead" class="site-header layout-<?php echo sanitize_html_class( str_replace('_', '-', siteorigin_setting( 'masthead_layout' ) ) ) ?> <?php if( siteorigin_setting( 'navigation_sticky' ) ) echo 'sticky-menu'; ?>" role="banner"
<?php if ( siteorigin_setting( 'navigation_sticky_scale' ) ) echo 'data-scale-logo="true"' ?> >
<header id="masthead" class="site-header layout-<?php echo sanitize_html_class( str_replace('_', '-', siteorigin_setting( 'masthead_layout' ) ) ) ?> <?php if( siteorigin_setting( 'navigation_sticky' ) ) echo 'sticky-menu'; ?>" <?php if ( siteorigin_setting( 'navigation_sticky_scale' ) ) echo 'data-scale-logo="true"' ?> >
<div class="container">

<div class="container-inner">
Expand All @@ -63,7 +62,7 @@
<?php endif ?>
</div><!-- .site-branding -->

<nav id="site-navigation" class="main-navigation" role="navigation">
<nav id="site-navigation" class="main-navigation">

<?php if ( siteorigin_page_setting( 'layout' ) !== 'stripped' ) : ?>

Expand Down
2 changes: 1 addition & 1 deletion inc/template-tags.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function siteorigin_north_the_post_navigation() {
return;
}
?>
<nav class="navigation post-navigation" role="navigation">
<nav class="navigation post-navigation">
<h2 class="screen-reader-text"><?php esc_html_e( 'Post navigation', 'siteorigin-north' ); ?></h2>
<div class="nav-links">
<?php
Expand Down
2 changes: 1 addition & 1 deletion index.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
get_header(); ?>

<div id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<?php if ( have_posts() ) : ?>

Expand Down
2 changes: 1 addition & 1 deletion page.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
get_header(); ?>

<div id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<?php while ( have_posts() ) : the_post(); ?>

Expand Down
2 changes: 1 addition & 1 deletion search.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
get_header(); ?>

<section id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<?php if ( have_posts() ) : ?>

Expand Down
2 changes: 1 addition & 1 deletion searchform.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<form method="get" action="<?php echo esc_url( site_url() ) ?>" role="search">
<form method="get" action="<?php echo esc_url( site_url() ) ?>">
<label for='s' class='screen-reader-text'><?php esc_html_e( 'Search for:', 'siteorigin-north' ); ?></label>
<input type="search" name="s" placeholder="<?php esc_attr_e('Search', 'siteorigin-north') ?>" value="<?php echo get_search_query() ?>" />
<button type="submit">
Expand Down
2 changes: 1 addition & 1 deletion sidebar.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
if ( ! in_array( siteorigin_page_setting( 'layout', 'default' ), array( 'default', 'full-width-sidebar' ), true ) ) return;
?>

<div id="secondary" class="widget-area" role="complementary" aria-label="<?php esc_attr_e( 'Main Sidebar', 'siteorigin-north' ); ?>">
<div id="secondary" class="widget-area" aria-label="<?php esc_attr_e( 'Main Sidebar', 'siteorigin-north' ); ?>">
<?php dynamic_sidebar( 'main-sidebar' ); ?>
</div><!-- #secondary -->
2 changes: 1 addition & 1 deletion single.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
get_header(); ?>

<div id="primary" class="content-area">
<main id="main" class="site-main" role="main">
<main id="main" class="site-main">

<?php while ( have_posts() ) : the_post(); ?>

Expand Down

0 comments on commit f610e07

Please sign in to comment.