-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix concurrency warnings #424
base: main
Are you sure you want to change the base?
Conversation
One thing I notice that's a bit different to #422's attempt is the |
@GeorgeElsham I think you used the Swift6 compiler in Swift 5 mode, this definitively not build on my side with Swift 6 |
What I did with the Package.swift file allows working with previous compiler versions and in both languages versions. Note that there is [email protected] too. |
@Alex293 You're right, I see. I'll try to fix it, thank you. |
I think we should gather the opinion of the author and the community if there is interest in using some of the constructs outside of SwiftUI. If not, I don’t think there is much sense in spending effort going further than what I did in the other branch. Did you identify any use cases for non main actor but sendable apis in this repo ? |
@davdroman can I ask your opinion ? Do you know about any potential use of this lib APIs outside of of SwiftUI/MainActor ? |
@Alex293 not off the top of my head, I'd find it strange that anyone would want to employ introspection in a background thread. |
@Alex293 Unfortunately I've had pretty limited time, but I've fixed the issues. It still uses |
An alternative to #422.
Fixes #418.