Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency warnings #424

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GeorgeElsham
Copy link

An alternative to #422.

Fixes #418.

@GeorgeElsham GeorgeElsham mentioned this pull request Jun 23, 2024
@GeorgeElsham
Copy link
Author

One thing I notice that's a bit different to #422's attempt is the Package.swift. Is there any information on what this is (being having a 6.0 version) about and is it needed / should I also include it here?

@Alex293
Copy link

Alex293 commented Jun 24, 2024

@GeorgeElsham I think you used the Swift6 compiler in Swift 5 mode, this definitively not build on my side with Swift 6

@Alex293
Copy link

Alex293 commented Jun 24, 2024

What I did with the Package.swift file allows working with previous compiler versions and in both languages versions. Note that there is [email protected] too.

@GeorgeElsham
Copy link
Author

@Alex293 You're right, I see. I'll try to fix it, thank you.

@Alex293
Copy link

Alex293 commented Jun 24, 2024

I think we should gather the opinion of the author and the community if there is interest in using some of the constructs outside of SwiftUI. If not, I don’t think there is much sense in spending effort going further than what I did in the other branch. Did you identify any use cases for non main actor but sendable apis in this repo ?

@Alex293
Copy link

Alex293 commented Jun 24, 2024

@davdroman can I ask your opinion ? Do you know about any potential use of this lib APIs outside of of SwiftUI/MainActor ?

@davdroman
Copy link
Collaborator

@Alex293 not off the top of my head, I'd find it strange that anyone would want to employ introspection in a background thread.

@GeorgeElsham
Copy link
Author

@Alex293 Unfortunately I've had pretty limited time, but I've fixed the issues. It still uses @MainActor only when appropriate. I've tested using Xcode 15.4 Beta and Xcode 16.0 Beta. Let me know if there are still any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift 6 complete concurrency warnings
3 participants