Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Set default lifetime for cachebuster identifier cache to 5 seconds in development context #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Aug 6, 2020

This makes regular flushing of this cache in development obsolete.

…nds in development context

This makes regular flushing of this cache in development obsolete.
@mficzel mficzel requested a review from grebaldi August 31, 2020 07:08
@mficzel
Copy link
Member Author

mficzel commented Aug 31, 2020

@grebaldi what do you think is rotating the token after 5sec in development a good or a bad idea?

@grebaldi
Copy link
Contributor

grebaldi commented Sep 2, 2020

@grebaldi what do you think is rotating the token after 5sec in development a good or a bad idea?

Not sure. I don't really know, what's the issue :) Are there scenarios in which we have to flush KlarSchiff in Development regularly? I mean, we usually just clear/deactivate the browser cache, right? Do we have issues with iframes, maybe?

@mficzel
Copy link
Member Author

mficzel commented Sep 2, 2020

@grebaldi Having to force reload in development Is the issue this wants to solve

@grebaldi
Copy link
Contributor

grebaldi commented Sep 2, 2020

I'd suggest to apply a NullBackend to Sitegeist_KlarSchiff_CacheBusterIdentifierCache (or reducing lifetime to 0, if possible) instead then. If the idea is to reload FE assets consistently, I don't see the point of having a 5 sec delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants