Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove need for shapeless.illTyped #270

Merged
merged 1 commit into from
Aug 2, 2021
Merged

remove need for shapeless.illTyped #270

merged 1 commit into from
Aug 2, 2021

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Aug 2, 2021

This will help getting rid of shapeless, probably needed for #210

@yanns yanns requested a review from xuwei-k as a code owner August 2, 2021 13:23
jrudolph
jrudolph approved these changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirthias sirthias merged commit 687185b into sirthias:master Aug 2, 2021
@sirthias
Copy link
Owner

sirthias commented Aug 2, 2021

Thank you, @yanns and @jrudolph!

@yanns yanns deleted the reduce_shapeless_dep branch August 5, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@xuwei-k xuwei-k Awaiting requested review from xuwei-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanns @sirthias @jrudolph