Fix explosion of empty lists in queries

sirikid · Aug 22, 2023 · 9ad2e84 · 9ad2e84
1 parent 22ee5b4
commit 9ad2e84
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/yuri_template/query_expander.ex b/lib/yuri_template/query_expander.ex
@@ -28,6 +28,9 @@ defmodule YuriTemplate.QueryExpander do
         value = if is_map(value), do: Enum.to_list(value), else: value
 
         case value do
+          [] ->
+            acc
+
           [{k1, v1} | kvs] ->
             Enum.reduce(
               kvs,

diff --git a/test/yuri_template/query_expander_test.exs b/test/yuri_template/query_expander_test.exs
@@ -21,4 +21,11 @@ defmodule YuriTemplate.QueryExpanderTest do
       {"{?keys,who}", "?keys=semi,%3B,dot,.,comma,%2C&who=fred"},
       {"{?list,half}", "?list=red,green,blue&half=50%25"}
     ]
+
+  test "empty keys explode" do
+    YuriTemplate.expand!(
+      "/category/{category_id}/{category_transliterate}/{page}{?specs*,per_page,sort,order}",
+      %{category_id: "1", category_transliterate: "x", page: "2", specs: []}
+    ) == "/category/1/x/2"
+  end
 end