Set valid decrypt fields for non-forwarding kernel targets#2126
Open
alexbakker wants to merge 1 commit into
Open
Set valid decrypt fields for non-forwarding kernel targets#2126alexbakker wants to merge 1 commit into
alexbakker wants to merge 1 commit into
Conversation
In case of the reverse direction of a subscription, no stream handler will be found. Previously, the decrypt struct was left zeroed, the kernel module rejected this with ``EINVAL`` and the daemon logged: ``` [core] Failed to push relay stream to kernel: Invalid argument ``` This patch sets ``REC_NULL``/``REH_NULL`` and marks the target as non-forwarding, matching what is expected by ``validate_srtp``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of the reverse direction of a subscription, no stream handler will be found. Previously, the decrypt struct was left zeroed, the kernel module rejected this with
EINVALand the daemon logged:This patch sets
REC_NULL/REH_NULLand marks the target as non-forwarding, matching what is expected byvalidate_srtp.