Unref ports after re-subscribe#2125
Closed
alexbakker wants to merge 1 commit into
Closed
Conversation
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe.
Contributor
Author
|
Looks like the |
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a) (cherry picked from commit 2e034c2)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a) (cherry picked from commit ba8d31d)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jun 29, 2026
Previously, the ports used for a monologue subscription would leak upon re-subscribe. ``__assign_stream_fds`` cleared the stream fd queue without decrementing the ref count. This prevented ``monologue_destroy`` from releasing the ports on unsubscribe. Closes #2125 Change-Id: Ib86290d6a35e2388e34098f2847f1e34b3db2c5d (cherry picked from commit 250df2a) (cherry picked from commit 135d648)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the ports used for a monologue subscription would leak upon re-subscribe.
__assign_stream_fdscleared the stream fd queue without decrementing the ref count. This preventedmonologue_destroyfrom releasing the ports on unsubscribe.