fix(2525): ensure non empty message when error of type string is passed, but no message #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing but no message
…to indicate sinon created the error
fatso83
reviewed
Sep 12, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2544 +/- ##
==========================================
- Coverage 96.03% 95.95% -0.09%
==========================================
Files 40 40
Lines 1892 1904 +12
==========================================
+ Hits 1817 1827 +10
- Misses 75 77 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Just fix the Prettier thingie and this is good to merge :) |
|
Done! |
mroderick
requested changes
Sep 13, 2023
Co-authored-by: Morgan Roderick <[email protected]>
|
Thank you for your contribution! 🥳 This has been published to the npm registry as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
When an error of type String and an undefined message are passed to
throwsException, ensure a non-empty error.messageSee issue: #2525
How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpassesNote: The branch currently causes this test to fail, so I'd appreciate guidance on whether expectations change, given this will result in a major semver change.